----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/#review132305 -----------------------------------------------------------
src/docker/executor.cpp (lines 396 - 397) <https://reviews.apache.org/r/46491/#comment196483> Consider starting health checks even if we have already been killed to ensure that tasks are health checked while in their kill grace period. src/launcher/executor.cpp (lines 516 - 518) <https://reviews.apache.org/r/46491/#comment196482> If a kill is in progress, consider adjusting the grace period if a new one is provided. - Alexander Rukletsov On May 7, 2016, 1:02 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46491/ > ----------------------------------------------------------- > > (Updated May 7, 2016, 1:02 p.m.) > > > Review request for mesos, Benjamin Bannier and Ben Mahler. > > > Bugs: MESOS-5240 > https://issues.apache.org/jira/browse/MESOS-5240 > > > Repository: mesos > > > Description > ------- > > Capture the state when a task has terminated (i.e., reaped) in a flag, > and use it to prevent calls to `killTask()` and `escalated()` when > they are executed after the task has terminated. > > > Diffs > ----- > > src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 > src/launcher/executor.cpp 4d5e2a9b876cd65be1386bf170dba2f71af86750 > src/launcher/http_command_executor.cpp > d2f15b0447d91f3a4cd92f07114cb366647cc7d3 > > Diff: https://reviews.apache.org/r/46491/diff/ > > > Testing > ------- > > `make check` on Mac OS 10.10.4 > > > Thanks, > > Alexander Rukletsov > >
