----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/#review132372 -----------------------------------------------------------
src/module/manager.cpp (line 357) <https://reviews.apache.org/r/47123/#comment196564> Should do the early exit: `if (moduleManifests.isNone()) { return Nothing(); }` That way the rest doesn't need to be indented. src/module/manager.cpp (line 358) <https://reviews.apache.org/r/47123/#comment196565> Should document the sort order / load order based on filenames inside the doc changes to accompany this (I don't see it anywhere currently) src/module/manager.cpp (line 377) <https://reviews.apache.org/r/47123/#comment196566> Is there a semantic difference between loading modules one at a time vs. just passing them all at once to loadManifest? I'm worried that the behavior here could differ slightly from the --modules flag which calls loadManifest with all the modules at once. - Cody Maloney On May 9, 2016, 5:10 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47123/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 5:10 p.m.) > > > Review request for mesos, Cody Maloney and Till Toenshoff. > > > Bugs: MESOS-5173 > https://issues.apache.org/jira/browse/MESOS-5173 > > > Repository: mesos > > > Description > ------- > > This allows the operator to use separate manifest JSON files for each > module. Previously, one had to merge all module manifest files into a > single JSON file before passing on to the master/agent. > > > Diffs > ----- > > src/master/flags.hpp e4cac1f8d688319c804e608b7229f458f779364a > src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee > src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 > src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 > src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5 > src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 > src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 > src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 > src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 > src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d > src/tests/flags.hpp ae232b1a087edfaf678bd1c67bc509efd6c740d8 > src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 > > Diff: https://reviews.apache.org/r/47123/diff/ > > > Testing > ------- > > Manual testing with: > 1. --module_dir > 2. --modules > 3. --module_dir in conjunction with --modules > > The first two succeeded while the third failed as expected. > > > Thanks, > > Kapil Arya > >
