----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47053/#review132452 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp (line 964) <https://reviews.apache.org/r/47053/#comment196626> What about the other files that use `::random()`? Can we do a full sweep? - Joris Van Remoortere On May 6, 2016, 4:17 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47053/ > ----------------------------------------------------------- > > (Updated May 6, 2016, 4:17 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Windows: [2/2] Used `os::random` in `slave.cpp`. > > > Diffs > ----- > > src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 > > Diff: https://reviews.apache.org/r/47053/diff/ > > > Testing > ------- > > OSX: make > Windows: msbuild > > > Thanks, > > Daniel Pravat > >