> On May 9, 2016, 10:38 a.m., Alexander Rojas wrote: > > src/tests/cluster.cpp, lines 424-432 > > <https://reviews.apache.org/r/46869/diff/3/?file=1375106#file1375106line424> > > > > Since callbacks are a libprocess property and not really additive, > > wouldn't this effectively overwrite the callbacks added by the master or > > any previously created agent?
Good point - I changed the logic in the master & agent startup code to only set authorization callbacks when the user explicitly specifies some authorization configuration when calling `StartMaster` or `StartSlave`. If the user provides their own authorizer, specifies a non-default authorizer name in the flags, or provides a list of ACLs in the flags, then `setCallbacks` will be called. This allows me to remove one of the reviews previously in this chain: https://reviews.apache.org/r/46876/ which was a hack to account for the fact that authorization callbacks were being set every time a master or agent was started. So now, whenever a caller expresses their intent to enable authorization by specifying an authorizer or a set of ACLs, we will set the authorization callbacks accordingly. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46869/#review132241 ----------------------------------------------------------- On May 10, 2016, 8:36 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46869/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 8:36 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > ------- > > The test cluster initialization code was altered > to enable authorization of libprocess-level HTTP > endpoints when a master or agent is launched > with authorization enabled. > > > Diffs > ----- > > src/tests/cluster.hpp 60ab3f72b6ff84324c9991d22d6e52cfe0cb6501 > src/tests/cluster.cpp db7262868164b1966a9824b8aa53dbe9c5af7c2f > > Diff: https://reviews.apache.org/r/46869/diff/ > > > Testing > ------- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
