> On May 9, 2016, 10:35 a.m., Alexander Rojas wrote: > > src/master/main.cpp, lines 430-431 > > <https://reviews.apache.org/r/46867/diff/4/?file=1375103#file1375103line430> > > > > Does it? The container `Option` is copied, but all copies of that > > `Option` will be refering to the same pointer. > > Greg Mann wrote: > The data gets copied as well, right? > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp#L60 > > So they'll all have copies of the same pointer? > > Greg Mann wrote: > Since the pointer gets copied I think this comment should remain; I'm > going to drop this comment, but let me know if you think it should be > reopened.
Ah sorry that was confusing :-) I think the comment in the code should remain, so I'm going to drop this comment on the RR. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46867/#review132240 ----------------------------------------------------------- On May 10, 2016, 8:30 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46867/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 8:30 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > ------- > > Code is added to the common headers and the > master/agent executables which sets authorization > callbacks for libprocess-level HTTP endpoints. > This allows these endpoints to be authorized. > > > Diffs > ----- > > src/common/http.hpp 6c6f2840bbf49d198b1db876cdf4af5ef49b0e27 > src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f > src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 > src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d > > Diff: https://reviews.apache.org/r/46867/diff/ > > > Testing > ------- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
