> On April 27, 2016, 11:44 p.m., Anand Mazumdar wrote: > > LGTM, just 2 minor nits. > > > > Also, as per our offline discussion: This doesn't handle scenarios where a > > client explicitly expects a error response encoded in a particular type > > specified via the `Accept` header. We would ideally want to file a JIRA > > issue and revisit it later once MESOS-4548 is resolved.
done. filed: MESOS-5363 > On April 27, 2016, 11:44 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 435 > > <https://reviews.apache.org/r/46725/diff/1/?file=1362761#file1362761line435> > > > > It seems weird that other places in the file use camel case > > nomenculture. Can we use `contentType` here to be consistent? I was told the new recommendation is to use snake case in libprocess and stout (cc @joris @mpark). But I agree, this file already uses camel case (including for contentType), so I'll stick with camel case for now. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46725/#review130867 ----------------------------------------------------------- On April 27, 2016, 5:26 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46725/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 5:26 a.m.) > > > Review request for mesos and Anand Mazumdar. > > > Bugs: MESOS-3739 > https://issues.apache.org/jira/browse/MESOS-3739 > > > Repository: mesos > > > Description > ------- > > The default Content-Type for HTTP responses that contain body is set > as "text/plain; charset=utf-8." > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297 > 3rdparty/libprocess/src/tests/encoder_tests.cpp > 61ec8d8722245179a929e954e6338606973b819b > > Diff: https://reviews.apache.org/r/46725/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
