-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47212/
-----------------------------------------------------------

Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.


Bugs: MESOS-5350
    https://issues.apache.org/jira/browse/MESOS-5350


Repository: mesos


Description
-------

In this code path, where the task uses the default command executor, 
and the agent is not dockerized
(i.e. `taskInfo.isSome() && flags.docker_mesos_image.isNone()`), 
the `executorEnvironment` function is called twice.

The first call is inside the `Container*` constructor called by 
`Container::create`.  Since `Container::create` gives passes `None` 
for the `environment` field, the constructor will call 
`executorEnvironment` to populate the `environment` field.  
The populated field is then accessible by `launchExecutorProcess`.


Diffs
-----

  src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 

Diff: https://reviews.apache.org/r/47212/diff/


Testing
-------

make check


Thanks,

Joseph Wu

Reply via email to