----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45671/#review132629 -----------------------------------------------------------
Patch looks great! Reviews applied: [45671] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 11, 2016, 2:51 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45671/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 2:51 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5267 > https://issues.apache.org/jira/browse/MESOS-5267 > > > Repository: mesos > > > Description > ------- > > Added version checking for dvdcli. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp > ef43c566a51d748cca318a7578db62ee3475656d > > Diff: https://reviews.apache.org/r/45671/diff/ > > > Testing > ------- > > make > make check > > Installed dvdcli as 0.2.0, start up mesos agent will be failed. > > root@kvm-002605:~/src/mesos/m1/mesos/build# dvdcli version > Binary: /usr/bin/dvdcli > SemVer: 0.2.0 > OsArch: Linux-x86_64 > Branch: v0.2.0 > Commit: b2f436bcd832fed904ac7d9b94cee7174ff59e18 > Formed: Thu, 21 Apr 2016 22:43:26 CST > > root@kvm-002605:~/src/mesos/m1/mesos/build# ./bin/mesos-slave.sh > --master=10.0.0.65:5050 --isolation=docker/volume,filesystem/linux > --work_dir=/tmp/mesos/slave > I0506 13:47:45.655879 26892 main.cpp:243] Build: 2016-05-05 17:10:08 by root > I0506 13:47:45.655985 26892 main.cpp:245] Version: 0.29.0 > I0506 13:47:45.655998 26892 main.cpp:252] Git SHA: > a138e2246a30c4b5c9bc3f7069ad12204dcaffbc > I0506 13:47:45.658900 26892 containerizer.cpp:178] Using isolation: > docker/volume,filesystem/linux,network/cni > I0506 13:47:45.664377 26892 linux_launcher.cpp:101] Using > /sys/fs/cgroup/freezer as the freezer hierarchy for the Linux launcher > Failed to create a containerizer: Could not create MesosContainerizer: Could > not create isolator 'docker/volume': Unable to create docker volume driver > client: The docker volume driver client request 'dvdcli' version as '0.1.0' > but the current version is '0.2.0' > > > Thanks, > > Guangya Liu > >
