----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47001/#review132654 -----------------------------------------------------------
Bad patch! Reviews applied: [47001] Failed command: ./support/apply-review.sh -n -r 47001 Error: 2016-05-11 13:44:56 URL:https://reviews.apache.org/r/47001/diff/raw/ [1441/1441] -> "47001.patch" [1] Total errors found: 0 Checking 1 files Error: No line in the commit message summary may exceed 72 characters. Full log: https://builds.apache.org/job/mesos-reviewbot/13002/console - Mesos ReviewBot On May 5, 2016, 4:15 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47001/ > ----------------------------------------------------------- > > (Updated May 5, 2016, 4:15 a.m.) > > > Review request for mesos, Gilbert Song and Jiang Yan Xu. > > > Bugs: MESOS-5308 > https://issues.apache.org/jira/browse/MESOS-5308 > > > Repository: mesos > > > Description > ------- > > There are two race conditions in ROOT_XFS_QuotaTest.NoCheckpointRecovery. > The first is when we were checking the disk resources consumed > without knowing whether the dd command had completed. We can just > eliminate this check since other tests cover the resource usage > case. The second race was installing the > MesosContainerizerProcess::___recover expectation after starting > the slave. We need to install this before starting. > > > Diffs > ----- > > src/tests/containerizer/xfs_quota_tests.cpp > 61ea2e55e5c71cb10f6c84d23c205169567e8c96 > > Diff: https://reviews.apache.org/r/47001/diff/ > > > Testing > ------- > > Fedora 23. > > $ mesos-tests --gtest_filter=ROOT_XFS_QuotaTest.NoCheckpointRecovery > --gtest_repeat=10000 --gtest_break_on_failure > > > Thanks, > > James Peach > >
