> On May 11, 2016, 12:26 p.m., Benjamin Bannier wrote: > > src/docker/executor.hpp, line 120 > > <https://reviews.apache.org/r/47205/diff/2/?file=1379825#file1379825line120> > > > > Any reason we wouldn't use an unordered map like e.g., a stout > > `hashmap` here and as function argument elsewhere in this patch?
This is meant to match the argument type of `docker->run`, which expects a `std::map`. > On May 11, 2016, 12:26 p.m., Benjamin Bannier wrote: > > src/docker/executor.cpp, line 502 > > <https://reviews.apache.org/r/47205/diff/2/?file=1379826#file1379826line502> > > > > stout `hashmap`? Same reason as above. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review132731 ----------------------------------------------------------- On May 11, 2016, 11:56 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47205/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 11:56 a.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya. > > > Bugs: MESOS-5350 > https://issues.apache.org/jira/browse/MESOS-5350 > > > Repository: mesos > > > Description > ------- > > This flag opens up a way for hooks to specify environment variables for > docker tasks. Existing hooks can only affect the environment variables > of docker executors. > > > Diffs > ----- > > src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 > src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 > > Diff: https://reviews.apache.org/r/47205/diff/ > > > Testing > ------- > > See later reviews in chain. > > > Thanks, > > Joseph Wu > >
