-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/#review132750
-----------------------------------------------------------




src/examples/test_http_framework.cpp (line 381)
<https://reviews.apache.org/r/46824/#comment196996>

    2 blank lines.



src/local/main.cpp (lines 52 - 53)
<https://reviews.apache.org/r/46824/#comment196997>

    why the need for "::" prefix here?



src/master/main.cpp (line 127)
<https://reviews.apache.org/r/46824/#comment196998>

    If `add` should be only called by derived classes, should `add` method be 
protected instead of public?



src/master/main.cpp (lines 207 - 223)
<https://reviews.apache.org/r/46824/#comment196999>

    where is this code moved from and why?



src/slave/main.cpp (line 97)
<https://reviews.apache.org/r/46824/#comment197000>

    why "::" prefix?


- Vinod Kone


On May 11, 2016, 12:14 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46824/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 12:14 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
>     https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While right now we can technically `add` variables to `Flags` classes
> which are not members, the in order to have correct copy semantics for
> `Flags` only member variables should be used.
> 
> Here we changed all instances to a full pointer-to-member syntax in
> the current code.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
>   src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
>   src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 
>   src/examples/dynamic_reservation_framework.cpp 
> 4ad5f4b846052ec9a2067a5ce21fb017f681debf 
>   src/examples/load_generator_framework.cpp 
> b22a09e1749d4b523addacad99858d7b6bde3403 
>   src/examples/long_lived_framework.cpp 
> 1740d7cb747d179d06e75153aa334b29e9cdf3c0 
>   src/examples/no_executor_framework.cpp 
> f578edfd99f3b7adf19cf06eab20696532c7b67d 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/examples/test_http_framework.cpp 
> db0463d894e9f2fb964781d16f8c622ce8a507a5 
>   src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
>   src/launcher/http_command_executor.cpp 
> c62fe3ee6ae06536cbb89ea208b669790efe4b39 
>   src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
>   src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
>   src/slave/container_loggers/logrotate.hpp 
> 16d92322079a69d8e6bed7830623c62f345cd51c 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> ad792def2bb3a1614d21ca28d858e400d2e3ede1 
>   src/slave/containerizer/mesos/launch.cpp 
> e22106b014c871e2184a15c2ab154a0674874e47 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
> 
> Diff: https://reviews.apache.org/r/46824/diff/
> 
> 
> Testing
> -------
> 
> Tested on various platforms in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to