----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47260/#review132788 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 2311) <https://reviews.apache.org/r/47260/#comment197038> s/ReviveAndSuppress/SuppressAndReviveOffers src/tests/hierarchical_allocator_tests.cpp (line 2348) <https://reviews.apache.org/r/47260/#comment197040> I think this comments is not needed as the function is self explained. src/tests/hierarchical_allocator_tests.cpp (line 2363) <https://reviews.apache.org/r/47260/#comment197039> You did not `active` a framework but only `revive` offers. s/after getting activated/after reviving offers - Guangya Liu On May 11, 2016, 9:15 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47260/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 9:15 p.m.) > > > Review request for mesos and Dario Rexin. > > > Bugs: MESOS-5279 > https://issues.apache.org/jira/browse/MESOS-5279 > > > Repository: mesos > > > Description > ------- > > Added 'ReviveAndSuppress' test for the allocator. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > e6101fdffe5e340619d79d821a2f5f891cb2dec7 > > Diff: https://reviews.apache.org/r/47260/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
