> On May 10, 2016, 8:34 a.m., Guangya Liu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 604
> > <https://reviews.apache.org/r/47095/diff/2/?file=1375994#file1375994line604>
> >
> >     This test may fail on CentOS 7, please refer to 
> > https://reviews.apache.org/r/44985/ and 
> > https://issues.apache.org/jira/browse/MESOS-4810
> 
> Shuai Lin wrote:
>     It's a bit awkward to use redirection if I use shell=false for the 
> `CommandInfo`, so I change `echo -n ...` to `/bin/echo -n ...`, hopefully it 
> would work. Can you give it a try on centos?

It will not work if you do not set shell as false, the reason is that your 
command will be run as `sh -c command` and `sh` cannot be found.

I did some test with your patch on centos 7, failed as expected.

I0512 00:05:14.570722  2907 exec.cpp:535] Executor sending status update 
TASK_RUNNING (UUID: cb95db8a-8c1b-4276-9aae-5744790b3540) for task 
cd090f3e-7d59-4529-87e0-72cc000bead3 of framework 
3d0009ac-5e31-41eb-a98a-db83e50a30bc-0000
I0512 00:05:14.571805  2838 slave.cpp:3221] Handling status update TASK_RUNNING 
(UUID: cb95db8a-8c1b-4276-9aae-5744790b3540) for task 
cd090f3e-7d59-4529-87e0-72cc000bead3 of framework 
3d0009ac-5e31-41eb-a98a-db83e50a30bc-0000 from executor(1)@9.21.51.124:54983
sh -c '/bin/echo -n $MESOS_SANDBOX > $MESOS_SANDBOX/env.txt'
Failed to exec: No such file or directory


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132393
-----------------------------------------------------------


On May 12, 2016, 1:42 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
>     https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> -------
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Reply via email to