----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46242/#review132861 -----------------------------------------------------------
Fix it, then Ship it! src/tests/reservation_endpoints_tests.cpp (line 1442) <https://reviews.apache.org/r/46242/#comment197146> Unlike other similar lines you are not using DEFAULT_CREDENTIAL.principal() here. Does this mean you want to intentionally use a different one? If so how do you ensure this is different? Just "principal" could become the same if someone else "creatively" updates DEFAULT_CREDENTIAL.principal later... Maybe add some random letters? On the other hand, I don't think it matters here, so we might as well create conformity to avoid confusion and use DEFAULT_CREDENTIAL.principal() instead. - Bernd Mathiske On April 14, 2016, 11:25 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46242/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 11:25 p.m.) > > > Review request for mesos, Adam B and Joris Van Remoortere. > > > Bugs: MESOS-5212 > https://issues.apache.org/jira/browse/MESOS-5212 > > > Repository: mesos > > > Description > ------- > > When a dynamic reservation is made by an operator > or framework with no principal, this patch removes > the check which enforced that the principal in > ReservationInfo must be None() in that case. > > > Diffs > ----- > > src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f > src/tests/master_validation_tests.cpp > 8a5bf9477596f13b2fb3a1348337ad2fe53a034d > src/tests/reservation_endpoints_tests.cpp > f014290ed9f279df4c774aeb7ce7bd38fd1cc854 > > Diff: https://reviews.apache.org/r/46242/diff/ > > > Testing > ------- > > `sudo make check` > > > Thanks, > > Greg Mann > >
