----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/#review132880 -----------------------------------------------------------
src/docker/spec.cpp (line 171) <https://reviews.apache.org/r/47199/#comment197156> s/'Labels'/`Labels` Ditto as following where you are using '' but not `` src/docker/spec.cpp (lines 226 - 230) <https://reviews.apache.org/r/47199/#comment197159> Does there are any possiblity that there are duplicat labels in `config` and `container_config`? If so, how to handle the case if there are duplicate labels with `config`? - Guangya Liu On 五月 12, 2016, 3:56 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47199/ > ----------------------------------------------------------- > > (Updated 五月 12, 2016, 3:56 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin > Klues. > > > Bugs: MESOS-5272 > https://issues.apache.org/jira/browse/MESOS-5272 > > > Repository: mesos > > > Description > ------- > > Implemented parsing docker labels in v1 spec. > > > Diffs > ----- > > src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d > > Diff: https://reviews.apache.org/r/47199/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
