-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/#review132997
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/flags/flag.hpp (line 23)
<https://reviews.apache.org/r/46669/#comment197295>

    whoops?



3rdparty/stout/include/stout/flags/flag.hpp (lines 52 - 57)
<https://reviews.apache.org/r/46669/#comment197296>

    Maybe `s/name_/name/` and `s/name/n/` or `s/name/name_`?



3rdparty/stout/include/stout/flags/flags.hpp (line 899)
<https://reviews.apache.org/r/46669/#comment197297>

    Past tense since the caller will log the warning after load completes?



3rdparty/stout/tests/flags_tests.cpp (lines 271 - 272)
<https://reviews.apache.org/r/46669/#comment197299>

    Can you update all of these existing tests to expect no warnings?



3rdparty/stout/tests/flags_tests.cpp (line 502)
<https://reviews.apache.org/r/46669/#comment197298>

    Can you use the `->` operator here?
    
    EXPECT?
    
    Also can you add an expectation on the message?


- Ben Mahler


On May 12, 2016, 10:42 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46669/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 10:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5370
>     https://issues.apache.org/jira/browse/MESOS-5370
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows callers of Flag to explicitly specify a flag name or its
> alias as deprecated. Loading of deprecated flag name will result in a
> deprecation warning being returned.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02 
>   3rdparty/stout/include/stout/flags/flag.hpp 
> d869904d13301fd4b3fdb037e6279d3a4018ac1e 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> 02584e28b938bba738c2e32b3cb7a04a47693853 
>   3rdparty/stout/include/stout/subcommand.hpp 
> 4d37c4afdcf4c3d6d511dd8a27916332b086afa7 
>   3rdparty/stout/tests/flags_tests.cpp 
> a2880a0afdc54faa4331ec8bd91929ce08c8f4a5 
> 
> Diff: https://reviews.apache.org/r/46669/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to