-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review133005
-----------------------------------------------------------


Fix it, then Ship it!





src/master/flags.cpp (lines 18 - 23)
<https://reviews.apache.org/r/46670/#comment197314>

    Mind committing this bit separately? You also need duration.hpp, error.hpp, 
none.hpp, stringify.hpp.


- Ben Mahler


On May 12, 2016, 10:38 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 10:38 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
>     https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `--authenticate` is made a deprecated alias for
> `--authenticate_frameworks` master flag. Also updated the example tests
> to use the new flag.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
>   src/examples/docker_no_executor_framework.cpp 
> 2b82b4f0e2424b98ea29fb08b21993b1713b364e 
>   src/examples/dynamic_reservation_framework.cpp 
> 4ad5f4b846052ec9a2067a5ce21fb017f681debf 
>   src/examples/java/TestExceptionFramework.java 
> 12bf60325567eb7a61c5811cbbac66f1b8e9ae2b 
>   src/examples/java/TestFramework.java 
> 295e54fde11fc9938d00ec03cbeaa7225b76a86c 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/examples/python/test_framework.py 
> 5f8e470721b303a60797c41db3c5587b89b5cf58 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
>   src/tests/script.cpp 5f2e2729b1d95b061bf3cbe0a052b397e366277d 
>   src/tests/test_http_framework_test.sh 
> 3a2b24cd5017f3535340cb8ade13b34e341cd7ce 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to