> On May 12, 2016, 5:08 p.m., Vinod Kone wrote: > > docs/configuration.md, line 1545 > > <https://reviews.apache.org/r/47303/diff/2/?file=1381285#file1381285line1545> > > > > just to confirm, all the text here is going to match the --help output > > after the flags patch lands?
Yes, I'm thinking to have 'agent' in all description, regardless of aliases of the flags. > On May 12, 2016, 5:08 p.m., Vinod Kone wrote: > > docs/architecture.md, line 12 > > <https://reviews.apache.org/r/47303/diff/2/?file=1381279#file1381279line12> > > > > mention that in slaveID is sent for driver based frameworks > > (deprecated) and agentID is sent for HTTP API based fraemworks. OK - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47303/#review132944 ----------------------------------------------------------- On May 12, 2016, 11:29 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47303/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 11:29 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3783 > https://issues.apache.org/jira/browse/MESOS-3783 > > > Repository: mesos > > > Description > ------- > > Rename 'slave' in documentations with 'agent'. However, not all of > them are renamed due to stickiness of class name, json response, > endpoint, etc. > > > Diffs > ----- > > docs/architecture.md 3eff931a9ebb91ae06c0c7bab6c6a17d5fdb8743 > docs/attributes-resources.md 7d687ffcba2bc4c9cc6d83172ac852abe4174c88 > docs/authentication.md 1084e638c913878de6742fcd459792272689b8e1 > docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 > docs/c++-style-guide.md fdd765e8a56974b25849a3509cbf99fa57fc7e27 > docs/committers.md 0ae0e920ab9e09ff985fd77eb5b3092b8499a3d7 > docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a > docs/container-image.md a7659de7a08d7badd185dac6bb43fb1fb6fbf5c8 > docs/containerizer-internals.md 6d050b9bb0c6f564e2fad83859a177bc8d742474 > docs/deploy-scripts.md af83d28e26b133bbf6b4fe821cb468c9d373bd57 > docs/docker-containerizer.md 6ec1cecd2e39bc4737688d8c4f6fc05e82c92023 > docs/documentation-guide.md 8239dcd908e2509797d7881d080ccbcf56f8fe4e > docs/doxygen-style-guide.md 1817aa0ac7ac7dd15a3d77fcab3451c874d1ef98 > docs/executor-http-api.md 2b362f616d02611a8eea37b88c60aabdbca8bfd4 > docs/external-containerizer.md 07a795f2352a169488400c948d6bc0501e01dc5e > docs/fetcher-cache-internals.md 7863fd2fc2b7ff8f45ad553b2764677ebec8a67d > docs/fetcher.md b23fdf2e7ae55cc807cd2ddb3b8dc4a7d3a79eb8 > docs/getting-started.md 546b04cfa3aced67477cda6da18754fcd76324ba > docs/high-availability-framework-guide.md > d5949508dafdf1a6e515663fa1524a81fe4ffba4 > docs/high-availability.md a8b4fce5e1bfcaec719ac7379dfc19e0ae43a928 > docs/home.md dc41fc4479e6c23650cd8ac78dcc4b9161d00721 > docs/mesos-containerizer.md 6f40c576e8402db1f56238e6a9cbacda0e166bac > docs/modules.md 28eb233a30b844b302fd95c03e4ff6647355cdfa > docs/monitoring.md 69d0f9848dcfed7069a8b25039cc3262bf406994 > docs/network-monitoring.md 1e503753a0aef127b555f072a4c8fb4768418e67 > docs/operational-guide.md 193cf0adf956ab9c32140875ad7434067da871b7 > docs/oversubscription.md 51eefb63da87607f991d7b10d6282dd73b3b092a > docs/persistent-volume.md e5f2836c8867d5221da9e4f89167850ef9dab8ec > docs/reconciliation.md 83cf15d1d188fc9c3a2a5b7cd1c8c8ec30c3fc6c > docs/release-guide.md 69b0a0f06574fea5ec6576325698068870306ae8 > docs/replicated-log-internals.md a04e774e12ee411beae84ef8c739e083f3469c25 > docs/slave-recovery.md ff584f0bd8b25421ce50c6fdaa38f5b98d93ff69 > docs/ssl.md d0fcd536a4d7fb86a9f80dfe4629c22df50686b2 > docs/testing-patterns.md 360d1c29e3ac0e4e99dcbcabdb2204e04eda7cea > docs/tools.md 11c8122ae61cb5788b2204a548a9a26650a26b97 > docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 > > Diff: https://reviews.apache.org/r/47303/diff/ > > > Testing > ------- > > Draft patch. Not going to be committed until flags&metrics being renamed. > > > Thanks, > > Jay Guo > >