-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47055/#review133122
-----------------------------------------------------------




src/webui/master/static/css/mesos.css (line 2)
<https://reviews.apache.org/r/47055/#comment197425>

    I think could put this overwritten section at the end of file. And add 
comments to descript it is used to increase contrast ratio.



src/webui/master/static/css/mesos.css (line 6)
<https://reviews.apache.org/r/47055/#comment197411>

    use 2 space indent here.



src/webui/master/static/css/mesos.css (line 9)
<https://reviews.apache.org/r/47055/#comment197415>

    We need adjust the style to
    
    ```
    .pagination > li > a,
    .pagination > li > span {
      color: #005580;
    }
    
    .pagination > .disabled > a,
    .pagination > .disabled > a:focus,
    .pagination > .disabled > a:hover,
    .pagination > .disabled > span,
    .pagination > .disabled > span:focus,
    .pagination > .disabled > span:hover {
    ...
    ```
    
    to make it more readable and avoid the line length limit.



src/webui/master/static/css/mesos.css (line 17)
<https://reviews.apache.org/r/47055/#comment197416>

    `span:hover{` should be `span:hover {`, missing a space here.



src/webui/master/static/css/mesos.css (line 21)
<https://reviews.apache.org/r/47055/#comment197420>

    I perfer to move `a` on the front of this section, to follow the order in 
bootstrap.



src/webui/master/static/css/mesos.css (line 30)
<https://reviews.apache.org/r/47055/#comment197419>

    Could not understand why change from `#ffffff` to `#555` here. I think you 
may want to change `background-color: #999999;` to `#555` here?



src/webui/master/static/css/mesos.css (line 42)
<https://reviews.apache.org/r/47055/#comment197412>

    use 2 space indent here.


- haosdent huang


On May 6, 2016, 8:58 a.m., Chen Nan Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47055/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 8:58 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5204
>     https://issues.apache.org/jira/browse/MESOS-5204
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Make the proper contrast ratio in web page for accessibility.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
> 
> Diff: https://reviews.apache.org/r/47055/diff/
> 
> 
> Testing
> -------
> 
> Ensuring that a contrast ratio of at least 4.5:1 exists between text (and 
> images of text) and background behind the text.
> 
> refer to https://www.w3.org/TR/WCAG20-TECHS/G18.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Reply via email to