> On May 13, 2016, 2:17 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 464 > > <https://reviews.apache.org/r/47274/diff/1/?file=1380254#file1380254line464> > > > > If we eliminate intermediate vector, we will be looping thorugh hashmap > > and list simultaneously. I can't think of a nice way to do it; we should > > probably use `for` with iterators.
Though we need the intermediate collection, I'd still say having the same type (`list`) and avoid using indices can make the code more readable. What'd you say? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47274/#review133094 ----------------------------------------------------------- On May 12, 2016, 12:48 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47274/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 12:48 a.m.) > > > Review request for mesos, Adam B and Alexander Rukletsov. > > > Bugs: MESOS-5336 > https://issues.apache.org/jira/browse/MESOS-5336 > > > Repository: mesos > > > Description > ------- > > Authorize what quota can be seen by GET_QUOTA_BY_ROLE. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d > include/mesos/authorizer/authorizer.proto > 32492a59ad95df3bb673ec42321518f86c11af59 > src/authorizer/local/authorizer.cpp > e95435327bb3b6f447e814b8657bce8084535346 > src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 > src/master/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c > src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64 > > Diff: https://reviews.apache.org/r/47274/diff/ > > > Testing > ------- > > Unit test. > > > Thanks, > > Zhitao Li > >
