----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/#review133171 -----------------------------------------------------------
Fix it, then Ship it! I'll fix outstanding issues for you and commit shortly. src/tests/hierarchical_allocator_tests.cpp (line 199) <https://reviews.apache.org/r/42386/#comment197460> Do we really need to distinguish between empty capabilities and not set capabilities? There is no difference in protobufs, right? Let's remove `Option<>` then. src/tests/hierarchical_allocator_tests.cpp (line 208) <https://reviews.apache.org/r/42386/#comment197461> I know what you try to say, but `type` is confusing. The best option is `capabilityType`, but if want something shorter, I'd suggest we go for `capability`. Moreover, imagine the future when we have more fields in `Capability` proto. src/tests/hierarchical_allocator_tests.cpp (lines 1202 - 1203) <https://reviews.apache.org/r/42386/#comment197462> Why do we need to define var that is used once in the immediate proximity of definition? - Alexander Rukletsov On May 6, 2016, 8:04 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42386/ > ----------------------------------------------------------- > > (Updated May 6, 2016, 8:04 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Artem > Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4801 > https://issues.apache.org/jira/browse/MESOS-4801 > > > Repository: mesos > > > Description > ------- > > Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 53a759ce0ebea87cc564a22cb2d34e54870f782b > > Diff: https://reviews.apache.org/r/42386/diff/ > > > Testing > ------- > > make > make tests > GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" > --verbose > > > Thanks, > > Guangya Liu > >
