> On 五月 13, 2016, 5:22 p.m., James Peach wrote: > > Looks fine. Consider switching to ``unique_ptr``, since we only check the > > ``fts_close`` error 1 of 3 times.
@James Peach, can you please show more detail for what do you mean? How to switch to `unique_prt`? Do you want me to submit another patch to address your comments? Here the `fts_close` was called 2 times for error handling and 1 time for normal close. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47336/#review133158 ----------------------------------------------------------- On 五月 13, 2016, 7:09 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47336/ > ----------------------------------------------------------- > > (Updated 五月 13, 2016, 7:09 a.m.) > > > Review request for mesos and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Fixed FTS handle leak issue in xfs isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > 80404c396ae98622a69ec290881226c1753d3626 > > Diff: https://reviews.apache.org/r/47336/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
