-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46498/#review133256
-----------------------------------------------------------



Some early comments, can you please split this to small patches? You can refer 
to https://reviews.apache.org/r/43021/ patch chain for how does run time 
isolator did this.

I saw that you also have patches https://reviews.apache.org/r/46107 and 
https://reviews.apache.org/r/46182/ , seems they are duplicate with this?


include/mesos/appc/spec.proto (line 58)
<https://reviews.apache.org/r/46498/#comment197539>

    blank line above



include/mesos/appc/spec.proto (lines 67 - 68)
<https://reviews.apache.org/r/46498/#comment197541>

    Why 6, 7? I think should be 2, 3



include/mesos/appc/spec.proto (line 68)
<https://reviews.apache.org/r/46498/#comment197540>

    s/environment/environments



include/mesos/slave/isolator.proto (line 21)
<https://reviews.apache.org/r/46498/#comment197542>

    blank line below



include/mesos/slave/isolator.proto (lines 86 - 91)
<https://reviews.apache.org/r/46498/#comment197543>

    s/Appc/AppC
    
    Why not `optional appc.spec.ImageManifest manifest = 6;`
    
    Or 
    
    message Appc {
      required appc.spec.ImageManifest manifest = 1;
    }
    
    optional Appc appc = 6;
    
    I think that the field in `AppC` should be `required`



src/Makefile.am (line 948)
<https://reviews.apache.org/r/46498/#comment197544>

    align with others



src/Makefile.am (line 971)
<https://reviews.apache.org/r/46498/#comment197545>

    align with others



src/slave/containerizer/mesos/containerizer.cpp (line 79)
<https://reviews.apache.org/r/46498/#comment197546>

    I prefer that you put it into a new #ifdef as it is a new isolator.
    
    #ifdef __linux__
    #include "slave/containerizer/mesos/isolators/mesos/runtime.hpp"
    #endif



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 27)
<https://reviews.apache.org/r/46498/#comment197547>

    kill this



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 199)
<https://reviews.apache.org/r/46498/#comment197548>

    kill this



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (lines 209 - 212)
<https://reviews.apache.org/r/46498/#comment197549>

    I think that we still have `argv`, why you are ignoring `argv` here? It is 
better use a table same as `DockerRuntimeIsolatorProcess` to describe the 
behavior here.



src/slave/containerizer/mesos/provisioner/provisioner.hpp (lines 24 - 25)
<https://reviews.apache.org/r/46498/#comment197550>

    #include <mesos/appc/spec.hpp>
    
    #include <mesos/docker/v1.hpp>


- Guangya Liu


On 五月 14, 2016, 4:20 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46498/
> -----------------------------------------------------------
> 
> (Updated 五月 14, 2016, 4:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add runtime for Appc Spec ex: command, workingdir and environment.
> 
> 
> Diffs
> -----
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 84fe52b6937c3b7d7628b17a2f045eec2f386b4d 
> 
> Diff: https://reviews.apache.org/r/46498/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Reply via email to