----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47403/#review133311 -----------------------------------------------------------
Patch looks great! Reviews applied: [47052, 47053, 47221, 47054, 41632, 47168, 47169, 47386, 47387, 47388, 47389, 47390, 47391, 47403] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 15, 2016, 10:28 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47403/ > ----------------------------------------------------------- > > (Updated May 15, 2016, 10:28 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3443 and MESOS-3658 > https://issues.apache.org/jira/browse/MESOS-3443 > https://issues.apache.org/jira/browse/MESOS-3658 > > > Repository: mesos > > > Description > ------- > > In Windows, the I/O subsystem will automatically convert linefeed > endings if the I/O is done on "text" files. For binary files, this > effect is almost never desirable. > > This commit will turn of these conversions for protobuf I/O operations. > > > Diffs > ----- > > 3rdparty/stout/include/stout/protobuf.hpp > eb4ac8cd738859a119f4f64bf52ae49a5bbef899 > > Diff: https://reviews.apache.org/r/47403/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
