> On 五月 13, 2016, 2:58 p.m., haosdent huang wrote:
> > src/webui/master/static/directives/tableHeader.html, line 3
> > <https://reviews.apache.org/r/46954/diff/1/?file=1370391#file1370391line3>
> >
> >     Seems `id` here is unnecessary, I think could remove it.
> >     
> >     ```
> >     <h3>{{headerTitle}}</h3>
> >     ```

I think both ok for this. Let's keep it. thanks


- Chen Nan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46954/#review133119
-----------------------------------------------------------


On 五月 6, 2016, 8:57 a.m., Chen Nan Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46954/
> -----------------------------------------------------------
> 
> (Updated 五月 6, 2016, 8:57 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
>     https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensuring that id attributes are unique on a Web page.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/directives/tableHeader.html 
> 448f67ef20c279fdd542890158fb9f96a10ebebc 
> 
> Diff: https://reviews.apache.org/r/46954/diff/
> 
> 
> Testing
> -------
> 
> Have checked with the patch by firebug, the ID of each table header is 
> different with each other.
> 
> For details refer to https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H93
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Reply via email to