----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46093/#review133342 -----------------------------------------------------------
Patch looks great! Reviews applied: [46093] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 16, 2016, 6:18 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46093/ > ----------------------------------------------------------- > > (Updated May 16, 2016, 6:18 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-5179 > https://issues.apache.org/jira/browse/MESOS-5179 > > > Repository: mesos > > > Description > ------- > > Enhanced the error message for invalid duration unit. > > > Diffs > ----- > > 3rdparty/stout/include/stout/duration.hpp > aea280830731a0e8c1aacd3fb6aef27291cc6f0b > > Diff: https://reviews.apache.org/r/46093/diff/ > > > Testing > ------- > > LiuGuangyas-MacBook-Pro:build gyliu$ ./bin/mesos-master.sh --offer_timeout=4cc > Failed to load flag 'offer_timeout': Failed to load value '4cc': Unknown > duration unit 'cc', the supported units are 'ns', 'us', 'ms', 'secs', 'mins', > 'hrs', 'days' and 'weeks' > > > Thanks, > > Guangya Liu > >
