----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47389/#review133422 -----------------------------------------------------------
3rdparty/stout/include/stout/os/constants.hpp (lines 20 - 28) <https://reviews.apache.org/r/47389/#comment197840> Can we have just the char versions? I think you can add support for `stringify(char)` to resolve the case where you want to construct just the string from a character. From the name `WINDOWS_SEPARATOR_CHAR` it' not clear what this means. Is this the path separator? The other variable is called `DIRECTORY_SEPARATOR`, which is more intuitive. Why can't the `char` versions be `constexpr`? 3rdparty/stout/include/stout/path.hpp (line 31) <https://reviews.apache.org/r/47389/#comment197841> Not sure what `char_separator` means. Can you name this differently? Is this just the `separator`? - Joris Van Remoortere On May 14, 2016, 11:58 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47389/ > ----------------------------------------------------------- > > (Updated May 14, 2016, 11:58 a.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Stout: Added support for correct path delimiters in Windows. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/constants.hpp > 438840aaef189ef4fb457b856790efb3b6333a7d > 3rdparty/stout/include/stout/path.hpp > ef538045a8b7a1e3d8962c869317d86a85e0259f > > Diff: https://reviews.apache.org/r/47389/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
