-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47409/#review133428
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/include/process/io.hpp (lines 72 - 99)
<https://reviews.apache.org/r/47409/#comment197849>

    Rather than copying the whole comment, snice this is just for the 
declaration, can we do this?
    ```
    /**
     * Performs a series of asynchronous reads, until EOF is reached.
     *
     * **NOTE**: when using this, ensure the sender will close the connection
     * so that EOF can be reached.
     *
     * @return The concatentated result of the reads.
     *     A failure will be returned if the file descriptor is bad, or if the
     *     file descriptor cannot be duplicated, set to close-on-exec,
     *     or made non-blocking.
     */
    Future<std::string> read(int fd);
    #ifdef __WINDOWS__
    // Windows `Handle` proxy.
    Future<std::string> read(HANDLE fd);
    #endif // __WINDOWS__
    ```


- Joris Van Remoortere


On May 16, 2016, 1:40 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47409/
> -----------------------------------------------------------
> 
> (Updated May 16, 2016, 1:40 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-5386
>     https://issues.apache.org/jira/browse/MESOS-5386
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Libprocess: Implemented `HANDLE` versions of file descriptor functions.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/io.hpp 
> 2f1e626c0eec7c965ddb7acbc9cfe890a621afd3 
>   3rdparty/libprocess/src/io.cpp 44dee23ec9fa958f8e047cf93b87a4031638ab5e 
> 
> Diff: https://reviews.apache.org/r/47409/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to