-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47411/#review133430
-----------------------------------------------------------


Fix it, then Ship it!





src/docker/docker.hpp (lines 123 - 124)
<https://reviews.apache.org/r/47411/#comment197851>

    Please add a small comment, and change the name.
    ```
    const process::Subprocess::IO& _stdout = process::Subprocess::PIPE(),
    const process::Subprocess::IO& _stderr = process::Subprocess::PIPE())
    ```



src/slave/slave.cpp (lines 486 - 487)
<https://reviews.apache.org/r/47411/#comment197853>

    ```
    resources->filter([](const Resource& _resource) {
    ```


- Joris Van Remoortere


On May 16, 2016, 1:46 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47411/
> -----------------------------------------------------------
> 
> (Updated May 16, 2016, 1:46 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Agent: Changed the names of symbols that are ambiguous on MSVC.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp da6e9a25b99079940958001128ee949cdb9b931b 
>   src/slave/slave.cpp feb9f291b4188aac1a63ab9cfae8349a048663b1 
> 
> Diff: https://reviews.apache.org/r/47411/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to