-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47363/#review133602
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/v1/executor.hpp (line 74)
<https://reviews.apache.org/r/47363/#comment198148>

    s/;/ override;/ ?


- Vinod Kone


On May 17, 2016, 3 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47363/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 3 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Bugs: MESOS-5302
>     https://issues.apache.org/jira/browse/MESOS-5302
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds a driver to v1 executor shim/adapter. This can
> be used by the command executor/docker executor to toggle
> between using the new/old API instead of duplicating the
> code like we did with `http_command_executor.cpp`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/executor.hpp adca287be3bb88c8b3298705740cb6bcbb3a09f0 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/executor/v0_v1executor.hpp PRE-CREATION 
>   src/executor/v0_v1executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47363/diff/
> 
> 
> Testing
> -------
> 
> make check (Later in the chain, we make the command executor use this 
> interface)
> So the existing tests should be able to test this out.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to