----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47365/#review133604 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On May 16, 2016, 11:50 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47365/ > ----------------------------------------------------------- > > (Updated May 16, 2016, 11:50 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5302 > https://issues.apache.org/jira/browse/MESOS-5302 > > > Repository: mesos > > > Description > ------- > > This is a blatant copy of `src/launcher/http_command_executor.cpp`. > This change makes reviewing code later in the chain easier. > Later in the chain, we would make this use the Shim/Adapter > to toggle between using the driver or the v1 API via an > environment variable. The existing `http_command_executor.cpp` > would be deleted. > > > Diffs > ----- > > src/launcher/executor.cpp 7d111e668e0a139a98bdeb959997843180b40452 > > Diff: https://reviews.apache.org/r/47365/diff/ > > > Testing > ------- > > make check > (this should not be committed on its own) > > > Thanks, > > Anand Mazumdar > >