----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47399/#review133615 -----------------------------------------------------------
Looking good. Have you tested manually the upgrade path? - Alexander Rukletsov On May 17, 2016, 6:26 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47399/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 6:26 p.m.) > > > Review request for mesos, Adam B and Alexander Rukletsov. > > > Bugs: MESOS-5155 > https://issues.apache.org/jira/browse/MESOS-5155 > > > Repository: mesos > > > Description > ------- > > New update_quotas ACL for both set and remove cases. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > b170330b236b83611d8477c0e45e520ef69aed9b > include/mesos/authorizer/authorizer.proto > 7d4aa32f42de538864508a0ba481d875917d9ab9 > src/authorizer/local/authorizer.hpp > d15d3a6c9f3d7c432e593cfe78cc48d672848d02 > src/authorizer/local/authorizer.cpp > bd47f4f02238e5052d9ab6caf338a2b51ddb752d > src/master/master.hpp 22a1538b8c2ca85cb8316aafe3f9a4476df833fc > src/master/quota_handler.cpp 86a2e175a3e1932961682c2a2d0cfe8210ee5fd0 > src/tests/authorization_tests.cpp f50ac69c32d0551a63391d97f31559ff4f414011 > src/tests/master_quota_tests.cpp 9bfa6ca58d5a92b857e8f2ce5cb835ddf18b44e6 > > Diff: https://reviews.apache.org/r/47399/diff/ > > > Testing > ------- > > Unit tests. > > > Thanks, > > Zhitao Li > >