-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47474/#review133633
-----------------------------------------------------------


Fix it, then Ship it!





src/logging/logging.cpp (line 202)
<https://reviews.apache.org/r/47474/#comment198186>

    Indentation. Missing period `.`. Please put backticks around 
`InstallFailureSignalHandler`. No need for the `()` in 
`InstallFailureSignalHandler()`.



src/logging/logging.cpp (lines 208 - 212)
<https://reviews.apache.org/r/47474/#comment198188>

    indentation.


- Joris Van Remoortere


On May 17, 2016, 5:34 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47474/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 5:34 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Disabled signal handlers in logging.cpp.
> 
> 
> Diffs
> -----
> 
>   src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 
> 
> Diff: https://reviews.apache.org/r/47474/diff/
> 
> 
> Testing
> -------
> 
> Windows: build/run
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Reply via email to