----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47473/#review133635 -----------------------------------------------------------
src/common/status_utils.hpp (lines 27 - 30) <https://reviews.apache.org/r/47473/#comment198190> It's not really a `no-op` right? It's just not implemented? Can we adjust the warning, and also add an appropriate `TODO` to implement this? Please add the JIRA in the `TODO`. - Joris Van Remoortere On May 17, 2016, 5:35 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47473/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 5:35 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > The return codes in Windows are not standardized. The function returns > an empty string and logs a warning. > > > Diffs > ----- > > src/common/status_utils.hpp fa8dbf1958efa13cfd10712a3215dbca693bcff9 > > Diff: https://reviews.apache.org/r/47473/diff/ > > > Testing > ------- > > OSX: make check > Windows: build/run > > > Thanks, > > Daniel Pravat > >
