-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47486/#review133637
-----------------------------------------------------------




3rdparty/libprocess/include/process/windows/subprocess.hpp (lines 129 - 136)
<https://reviews.apache.org/r/47486/#comment198193>

    Can we use `strings::replace` here?
    Is there a test that covers this? Can we add a JIRA if not?


- Joris Van Remoortere


On May 17, 2016, 7:19 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47486/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The command line for the containerizer has the command encoded
> as JSON. Non escaped quotes are removed during the containerizer
> startup and the JSON processed is invalid.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/windows/subprocess.hpp 
> 551770b9ec24b880c13441f413c5d1871fbf5c3a 
> 
> Diff: https://reviews.apache.org/r/47486/diff/
> 
> 
> Testing
> -------
> 
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Reply via email to