-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47463/#review133640
-----------------------------------------------------------


Fix it, then Ship it!





docs/cni.md (line 2)
<https://reviews.apache.org/r/47463/#comment198200>

    one blank line between the paragraph and the subtitle. Please fix all other 
places.



docs/cni.md (line 133)
<https://reviews.apache.org/r/47463/#comment198209>

    I would mention that nsenter can also be used to achieve the same goal. One 
just need to get the pid (which can be get from the bind mount as well).
    
    You don't have to show the commands, just mention it in the text.



docs/cni.md (line 176)
<https://reviews.apache.org/r/47463/#comment198211>

    I would typically introduce a blank line above in such cases. Please fix 
them all.



docs/cni.md (line 190)
<https://reviews.apache.org/r/47463/#comment198210>

    2 lines part between subsections. Please fix them all.



docs/cni.md (line 221)
<https://reviews.apache.org/r/47463/#comment198208>

    kill this line.



docs/cni.md (line 223)
<https://reviews.apache.org/r/47463/#comment198212>

    Ditto on adding a new line above.


- Jie Yu


On May 17, 2016, 3:22 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47463/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4771
>     https://issues.apache.org/jira/browse/MESOS-4771
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for `network/cni` isolator.
> 
> 
> Diffs
> -----
> 
>   docs/cni.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47463/diff/
> 
> 
> Testing
> -------
> 
> Build the documentation website and verified the rendering.
> 
> You can review a rendering of the markdown on my github:
> https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to