-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47482/#review133647
-----------------------------------------------------------




3rdparty/stout/include/stout/elf.hpp (line 77)
<https://reviews.apache.org/r/47482/#comment198213>

    Dont we have to close the open file in error cases?



3rdparty/stout/include/stout/elf.hpp (line 94)
<https://reviews.apache.org/r/47482/#comment198215>

    Maybe break out after finding DYNAMIC section?



3rdparty/stout/include/stout/elf.hpp (line 184)
<https://reviews.apache.org/r/47482/#comment198216>

    emplace_back?



3rdparty/stout/include/stout/elf.hpp (line 196)
<https://reviews.apache.org/r/47482/#comment198214>

    const?


- Jojy Varghese


On May 17, 2016, 7:17 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47482/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5400
>     https://issues.apache.org/jira/browse/MESOS-5400
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Right now we are able to parse ELF formatted shared libraries and
> extract their canonical SONAME and external library dependencies. In
> the future, we should add support for fully parsing an ELf file for
> easy access to all of its contents.
> 
> The current implementation relies on libelf. We should probably remove
> this dependency in future versions (mostly since the headers for
> libelf are not installed on a standard Linux distribution by default).
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/configure.ac ada1e22c72875fe9d557f07e4846128be0bcef13 
>   3rdparty/stout/include/stout/elf.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47482/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to