> On May 17, 2016, 11:18 p.m., Vinod Kone wrote:
> > Can you attach before and after screenshots to this review?
> > 
> > Also, I'm assuming these changes do not adversely affect the desktop 
> > version?

Posted in testing section. For the first sight diferrences could be hard to 
notice becouse only spacing has changed in PC version. In mobile changes are 
obvious. I have a problem with generating nice screenshot from page with 
vertical scrolls that why old version could be turncated.


> On May 17, 2016, 11:18 p.m., Vinod Kone wrote:
> > site/source/index.html.md, line 6
> > <https://reviews.apache.org/r/47499/diff/1/?file=1386240#file1386240line6>
> >
> >     i'm assuming killing this safe to do?

It'll add padding


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133656
-----------------------------------------------------------


On May 17, 2016, 10:48 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 10:48 p.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
>     https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -----
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> -------
> 
> Manually checked some random pages in different sizes.
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Reply via email to