-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46761/
-----------------------------------------------------------

(Updated 五月 18, 2016, 2:16 a.m.)


Review request for mesos, Benjamin Mahler, Kevin Klues, Maxim Khutornenko, and 
Vinod Kone.


Changes
-------

rebase code and update the urls according to Vinod's comments


Bugs: mesos-3779
    https://issues.apache.org/jira/browse/mesos-3779


Repository: mesos


Description
-------

This patch did the following changes in WebUI:
1. Slave/Agent Rename on web page
2. Slave/Agent Rename in web url
3. Slave/Agent Rename in JS class/method/attribute
4. Slave/Agent Rename in comments

For the JSON data returned from server that contains
term 'slave', the change is not included.


Diffs (updated)
-----

  CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 
  src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
  src/webui/master/static/browse.html 04a4600f0c762a2412ddee078ba2c173d595aa8d 
  src/webui/master/static/framework.html 
041513b0e005e8b54ca9723741b21b136ff61ca6 
  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
  src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
  src/webui/master/static/js/app.js 543fe9efb9618b311c7f21b7771a251738b01a91 
  src/webui/master/static/js/controllers.js 
8d9021cc89e54ae3a4151ff7f399733f5a7376dd 
  src/webui/master/static/js/services.js 
fa5cc35c1ef0e8ec149ed88852837058ec6ab13c 
  src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
  src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
  src/webui/master/static/slave_executor.html 
99b23ed9e85011a66bad780fb2d3076e946821a6 
  src/webui/master/static/slave_framework.html 
176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
  src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 

Diff: https://reviews.apache.org/r/46761/diff/


Testing
-------

cd mesos
./bootstrap
mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make
make check
make install

start mesos master/agent and run a sample framework, then open browser and goto 
<mesos-master-host>:<port> to check all the strings on web page and url

Tested the following slave relevant urls in browser, and it redirect to 
corresponding agent urls:

  '/slaves', redirectTo: '/agents'

  '/slaves/:agent_id', redirectTo: '/agents/:agent_id'

  '/slaves/:agent_id/frameworks/:framework_id', redirectTo: 
'/agents/:agent_id/frameworks/:framework_id'

  '/slaves/:agent_id/frameworks/:framework_id/executors/:executor_id', 
redirectTo:     
'/agents/:agent_id/frameworks/:framework_id/executors/:executor_id'

  '/slaves/:agent_id/frameworks/:framework_id/executors/:executor_id/browse', 
redirectTo: 
'/agents/:agent_id/frameworks/:framework_id/executors/:executor_id/browse'

  '/slaves/:agent_id/browse', redirectTo: '/agents/:agent_id/browse'


Thanks,

zhou xing

Reply via email to