> On May 18, 2016, 6:39 p.m., Vinod Kone wrote:
> > docs/cni.md, line 5
> > <https://reviews.apache.org/r/47463/diff/3/?file=1386244#file1386244line5>
> >
> >     Should we make it explicit that this is not supported for 
> > DockerContainerizer?

I don't think we should be explicit about the `DockerContainerizer` here. I 
mention in the introduction that the `network/cni` isolator is for the 
`MesosContainerizer`. The title also states that this is for Mesos containers. 
We are also going to have a separate page for `Networking with 
DockerContainerizer`. Was also thinking that in the home page we can link this 
page using the title "Networking with MesosContainerizer".


> On May 18, 2016, 6:39 p.m., Vinod Kone wrote:
> > docs/cni.md, lines 100-101
> > <https://reviews.apache.org/r/47463/diff/3/?file=1386244#file1386244line100>
> >
> >     What happens if a network that is in use (by containers) is removed 
> > from the config and agent restarted? What if the network config is updated? 
> > Is that all safe?

Thanks !! This is an important point that I missed. Currently we are not 
checkpointing the CNI configuration for a given container. This implies that if 
the current CNI config is modified or deleted, it won't affect container 
operation, or even Agent restart, but it will impact deletion of containers. 
Since the plugin information in the CNI config might have changed, resulting in 
the plugin throwing an error when it tries to delete the veth and release IP 
address from the container network namespace.

I will add a `### Limiations` section describing this behavior. We have 
https://issues.apache.org/jira/browse/MESOS-5310 to address this issue.


> On May 18, 2016, 6:39 p.m., Vinod Kone wrote:
> > docs/cni.md, lines 114-119
> > <https://reviews.apache.org/r/47463/diff/3/?file=1386244#file1386244line114>
> >
> >     Do all these configs result in the same networking behavior?
> >     
> >     -- network/cni flag is disabled
> >     -- NetworkInfo is not set and flag is enabled
> >     --- NetworkInfo is not set and flag is disabled
> >     -- NetworkInfo is set but name is not and flag is enabled
> >     -- NetworkInfo is set but name is not and flag is disabled
> >     
> >     -- all the above options with 0.28.0; without the flag ofcourse

Yes. In all the above cases the behavior will be that the container will use 
the host network namespace, effectively joining the host naetwork.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47463/#review133782
-----------------------------------------------------------


On May 18, 2016, 1:31 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47463/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 1:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, Kevin Klues, Neil Conway, 
> Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-4771
>     https://issues.apache.org/jira/browse/MESOS-4771
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for `network/cni` isolator.
> 
> 
> Diffs
> -----
> 
>   docs/cni.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47463/diff/
> 
> 
> Testing
> -------
> 
> Build the documentation website and verified the rendering.
> 
> You can review a rendering of the markdown on my github:
> https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to