-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133865
-----------------------------------------------------------




CHANGELOG (line 59)
<https://reviews.apache.org/r/47400/#comment198514>

    s/set_quotas/`set_quotas`
    s/remove_quotas/`remove_quotas`
    
    s/in/in favor
    
    Do we need to mention `get_quotas` here?



CHANGELOG (line 60)
<https://reviews.apache.org/r/47400/#comment198516>

    s/update_quotas/`update_quotas`



CHANGELOG (line 61)
<https://reviews.apache.org/r/47400/#comment198517>

    I think ` This is applicable to both local authorizer as well as any custom 
authorizer module.` can be removed.
    
    The CHANGELOG only need to clarify the update



docs/authorization.md (lines 128 - 129)
<https://reviews.apache.org/r/47400/#comment198518>

    Can you please link the `quota` keyword to quota document?



docs/authorization.md (line 524)
<https://reviews.apache.org/r/47400/#comment198520>

    blank line above



docs/authorization.md (line 551)
<https://reviews.apache.org/r/47400/#comment198519>

    blank line above



docs/upgrades.md (line 175)
<https://reviews.apache.org/r/47400/#comment198521>

    Does this belong to your patch? Why copy here?



docs/upgrades.md (line 175)
<https://reviews.apache.org/r/47400/#comment198522>

    Why moving this part to quota section?


- Guangya Liu


On May 18, 2016, 4:53 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
>     https://issues.apache.org/jira/browse/MESOS-5155
>     https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 
>   docs/authorization.md 9a359dc1c5576e9871c0747d02852bde35d67a3e 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 59274362fa6ec1e5857176fd5f8fd78c381f0d52 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Reply via email to