----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47485/#review133888 -----------------------------------------------------------
Ship it! Kevin and I went over this and made some adjustments, mostly related to variable naming, some comment changes, a few changes to the code style. - Benjamin Mahler On May 19, 2016, 5:38 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47485/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 5:38 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5398 > https://issues.apache.org/jira/browse/MESOS-5398 > > > Repository: mesos > > > Description > ------- > > Added utility for parsing ld.so.cache on linux. > > > Diffs > ----- > > configure.ac 63ea028fa89ba8e164e98226fc7ddcffd8b045c8 > src/Makefile.am 571d2a5cca1f78ed55131fe830e8b17f2bcf0471 > src/linux/ldcache.hpp PRE-CREATION > src/linux/ldcache.cpp PRE-CREATION > src/tests/ldcache_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/47485/diff/ > > > Testing > ------- > > GTEST_FILTER="LdcacheTest.Parse" make check -j > > > Thanks, > > Kevin Klues > >
