> On May 18, 2016, 10:17 a.m., Alexander Rukletsov wrote:
> > docs/authorization.md, lines 566-580
> > <https://reviews.apache.org/r/46501/diff/8/?file=1385425#file1385425line566>
> >
> >     It's hard to remember that this doc should be updated if changes to the 
> > proto are made. Can we reference the code instead? Could you please follow 
> > up with a fix?
> 
> Alexander Rojas wrote:
>     If you look at the history, other reviewers were against linking to the 
> code here.

If I look at https://reviews.apache.org/r/47505/ I see how easy is to forget to 
update this code. I leave this decision to you.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46501/#review133711
-----------------------------------------------------------


On May 17, 2016, 1:11 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46501/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 1:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4785
>     https://issues.apache.org/jira/browse/MESOS-4785
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The API of the authorization has been changing constantly over the
> last few versions. This patch attempts to update the documentation to
> the those changes into account.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
> 
> Diff: https://reviews.apache.org/r/46501/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to