> On May 19, 2016, 10:48 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/read.hpp, line 118 > > <https://reviews.apache.org/r/47585/diff/1/?file=1387867#file1387867line118> > > > > Let's just wrap this in a `std::unique_ptr<char[]>` instead! > > Benjamin Bannier wrote: > +1, or just a `std::string` since most probably the reflex might be to > *always* use `Owned` instead of `std::unique_ptr`, but that one cannot be > used to manage dynamic arrays. > > Jan Schlicht wrote: > We could also use a `std::vector<char>` or instead, like > ``` > std::vector<char> buffer; > buffer.reserve(BUFSIZ); > ```
Please see the discussion at https://reviews.apache.org/r/47481/ on why this isn't any of the suggested types. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47585/#review133900 ----------------------------------------------------------- On May 19, 2016, 10:42 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47585/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 10:42 a.m.) > > > Review request for mesos, Benjamin Bannier and Bernd Mathiske. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/read.hpp > c39140fc17c5b4869c3a90c187ebcb9c284397f4 > > Diff: https://reviews.apache.org/r/47585/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
