> On May 19, 2016, 2:41 p.m., Tomasz Janiszewski wrote:
> > site/source/index.html.erb, line 15
> > <https://reviews.apache.org/r/47587/diff/2/?file=1387887#file1387887line15>
> >
> >     Do we have line length policy for site files?
> 
> haosdent huang wrote:
>     Thank you very much for your reviews, let me fix it.

For some url like
```
<a 
href="https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=<%=
 item.target_version %>">CHANGELOG</a>
```
I keep them because they could not be break.

For the script copy from twitter embed guide, I keep them as well.

```
<script>!function(d,s,id){var 
js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document,
 'script', 'twitter-wjs');</script>
```

For other cases, I adjusted them to match 80 characters limit. May you help to 
review this patch again? Thank you in advance.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47587/#review133949
-----------------------------------------------------------


On May 19, 2016, 4:16 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47587/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-1495
>     https://issues.apache.org/jira/browse/MESOS-1495
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created separate local data file to manage releases information.
> 
> 
> Diffs
> -----
> 
>   site/data/releases.yml PRE-CREATION 
>   site/source/downloads.html.erb PRE-CREATION 
>   site/source/downloads.html.md 7f0b07d122bfb52f47d1424730d69749f615fc25 
>   site/source/index.html.erb PRE-CREATION 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47587/diff/
> 
> 
> Testing
> -------
> 
> Test by re-generate the website in my local machine.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to