> On May 19, 2016, 2:47 p.m., Neil Conway wrote:
> > docs/cni.md, line 3
> > <https://reviews.apache.org/r/47463/diff/3/?file=1386244#file1386244line3>
> >
> >     Phrasing is awkward: who is "we", and when "have we introduced" the CNI 
> > isolator? Better would be: "The Mesos `network/cni` isolator allows 
> > containers launched using the `MesosContainerizer` to be attached to 
> > several different types of IP networks."

I revamped the introduction completely. Would be great if you can have another 
look at it.


> On May 19, 2016, 2:47 p.m., Neil Conway wrote:
> > docs/cni.md, line 40
> > <https://reviews.apache.org/r/47463/diff/3/?file=1386244#file1386244line40>
> >
> >     Saying "network namespace" three times in one sentence seems 
> > regrettable.

Re-wrote this paragraph.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47463/#review133937
-----------------------------------------------------------


On May 19, 2016, 6:38 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47463/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, Kevin Klues, Neil Conway, 
> Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-4771
>     https://issues.apache.org/jira/browse/MESOS-4771
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for `network/cni` isolator.
> 
> 
> Diffs
> -----
> 
>   docs/cni.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47463/diff/
> 
> 
> Testing
> -------
> 
> Build the documentation website and verified the rendering.
> 
> You can review a rendering of the markdown on my github:
> https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to