-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47471/#review134054
-----------------------------------------------------------




src/examples/test_framework.cpp (line 207)
<https://reviews.apache.org/r/47471/#comment198692>

    I have another patch in your branch for handling the flags. Please merge 
and repost.


- Daniel Pravat


On May 17, 2016, 4:02 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47471/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 4:02 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3610
>     https://issues.apache.org/jira/browse/MESOS-3610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> logging::Flags contructor calls add() on Flags_base
> that uses RTTI. Compiler behaviour varies.
> 
> 
> Diffs
> -----
> 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/examples/test_http_framework.cpp 
> db0463d894e9f2fb964781d16f8c622ce8a507a5 
>   src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
>   src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
>   src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
>   src/logging/flags.hpp fe40a11c6a5e3ef44ecf008d1aa03d4e74e59859 
>   src/logging/flags.cpp db8fd3e0328f0f8be6968e58b173ce4c11c8adcb 
>   src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 
>   src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
>   src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
> 
> Diff: https://reviews.apache.org/r/47471/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to