----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47633/#review134094 -----------------------------------------------------------
Fix it, then Ship it! Thank you for your patch. For summary and description, it should be limited in 72 characters, otherwise could not pass jenkins build. src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (line 3926) <https://reviews.apache.org/r/47633/#comment198741> I suggest to change comment like ``` // Disable IPv6 when IPv6 module was loaded as IPv6 packets won't be forwarded // anyway. ``` - haosdent huang On May 20, 2016, 3:54 a.m., Zhengju Sha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47633/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 3:54 a.m.) > > > Review request for mesos, haosdent huang, Jie Yu, and Cong Wang. > > > Bugs: MESOS-5381 > https://issues.apache.org/jira/browse/MESOS-5381 > > > Repository: mesos > > > Description > ------- > > Isolation/networking: check if IPv6 is loaded before trying to disable it > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > ad792def2bb3a1614d21ca28d858e400d2e3ede1 > > Diff: https://reviews.apache.org/r/47633/diff/ > > > Testing > ------- > > Enniornment and steps: > 1. Enable mesos-slave --isolation=network/port_mapping on CentOS7.2 with > kernel version: 3.10.0-327.10.1.el7.x86_64 > 2. Create application on marathon framework with commands such as "echo > hello" using MesosContainerizer > 3. Load IPv6 module by removing "ipv6.disable=1" of GRUB_CMDLINE_LINUX in > /etc/default/grub > 4. Disable IPv6 module by adding "ipv6.disable=1" of GRUB_CMDLINE_LINUX in > /etc/default/grub > > Now mesos can run both of the testcases successfully. > > > Thanks, > > Zhengju Sha > >
