----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47528/#review134346 -----------------------------------------------------------
src/tests/master_validation_tests.cpp (line 451) <https://reviews.apache.org/r/47528/#comment199144> Please add a test description for every new test. src/tests/master_validation_tests.cpp (line 454) <https://reviews.apache.org/r/47528/#comment199145> Where are we setting the principal for DiskInfo.Persistence? How is this block of code any different from the one below? - Bernd Mathiske On May 18, 2016, 1:02 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47528/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 1:02 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. > > > Bugs: MESOS-5005 > https://issues.apache.org/jira/browse/MESOS-5005 > > > Repository: mesos > > > Description > ------- > > The master validation tests are updated to include the > new `validate()` signature, and a new test is added, > `CreateOperationValidationTest.NonMatchingPrincipal`, > to ensure that a non-matching creator principal will > be invalidated. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > ca4442aa1ef0087a7d058d1b3aa430a1dbc16960 > > Diff: https://reviews.apache.org/r/47528/diff/ > > > Testing > ------- > > `make check` was used to test on OSX at the end of this review chain. > > > Thanks, > > Greg Mann > >
