-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47594/#review134380
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 251 - 252)
<https://reviews.apache.org/r/47594/#comment199171>

    Please align the error messages:
    ```
    return Error(
        "Cannot ..."
        " ...");
    ```


- Jie Yu


On May 19, 2016, 2:31 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47594/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 2:31 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5413
>     https://issues.apache.org/jira/browse/MESOS-5413
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Skipped the bind mount of CNI net info root dir if possible.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> dae369aadb940150aa806b28d9269e3d88cf57ed 
> 
> Diff: https://reviews.apache.org/r/47594/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to